Refactor LogFileData
The following discussion from !52 (merged) should be addressed:
With this dedicated class for column-based logfiles, should me move the functionality related to "m_columnNames" from
LogFileData
to this class? Otherwise the "support for column handling" is somewhat splitted between these two classes...We definitely should do this - however we then break the API. I'd suggest that we postpone this to a later refactoring - are you ok with that?
I thought about this issue (and the member
m_columnNames
) and how to properly solve it. I think I got an idea on how to do this "properly". Basically we could makeLogFile
use 3 template parameters (LogFileData
,LogFileHeader
,LogFileFooter
) with corresponding base classes. In the header/footer encoding section of theLogFile
we then could create instaces ofLogFileHeader
(containingm_columnNames
) /LogFileFooter
instead ofLogFileData
. However, as you said this will break API compatibility, thus we can discuss this for a future release (v2.0?). We can keep the proposed extension as it is now...