Fixed TrackballCameraProvider::onRenderTargetSizeChanged()

Fixed Cppcheck issue in mprrenderer.cpp
Updated visual regression testing reference images (checked)

refs #141

ext/cgt/navigation/trackball.cpp

@@ -558,6 +558,7 @@ void Trackball::timerEvent(TimeEvent* e) {
 
 void Trackball::setWindowRatio(float r) {
     getCamera()->setWindowRatio(r);
+    getCamera()->setRatio(r);
     hcam_->update();
 }
 

modules/base/processors/trackballcameraprovider.cpp

@@ -158,9 +158,9 @@ namespace campvis {
     }
 
     void TrackballCameraProvider::onRenderTargetSizeChanged(const AbstractProperty* prop) {
-        _trackball->setViewprtSize(_canvasSize->getValue());
         float ratio = static_cast<float>(_canvasSize->getValue().x) / static_cast<float>(_canvasSize->getValue().y);
-        p_aspectRatio.setValue(ratio);
+        _trackball->setViewprtSize(_canvasSize->getValue());
+        _trackball->setWindowRatio(ratio);
         invalidate(INVALID_RESULT);
     }
 

modules/vis/processors/mprrenderer.cpp

@@ -94,7 +94,7 @@ namespace campvis {
                     // Construct the clipping plane in world coordinates
                     cgt::vec3 n = cgt::normalize(p_planeNormal.getValue());
                     cgt::vec3 temp(1.0, 0.0, 0.0);
-                    if (abs(cgt::dot(temp, n) > 0.9))
+                    if (abs(cgt::dot(temp, n)) > 0.9)
                         temp = cgt::vec3(0.0, 1.0, 0.0);
 
                     cgt::vec3 inPlaneA = cgt::normalize(cgt::cross(n, temp)) * 0.5f * p_planeSize.getValue();

test/modules/pipelineresultimagetest.cpp

@@ -102,7 +102,8 @@ protected:
 
     void execute() {
         if (_pipeline != nullptr) {
-            _pipeline->executePipeline();
+            for (size_t i = 0; i < _pipeline->getProcessors().size(); ++i)
+                _pipeline->executePipeline();
 
             // write result image
             _imageWriter.p_inputImage.setValue(_pipeline->getRenderTargetID());