Notice to GitKraken users: A vulnerability has been found in the SSH key generation of GitKraken versions 7.6.0 to 8.0.0 (https://www.gitkraken.com/blog/weak-ssh-key-fix). If you use GitKraken and have generated a SSH key using one of these versions, please remove it both from your local workstation and from your LRZ GitLab profile.

21.10.2021, 9:00 - 11:00: Due to updates GitLab may be unavailable for some minutes between 09:00 and 11:00.

Commit 32780169 authored by Artur Grunau's avatar Artur Grunau
Browse files

Disable BUILD_SHARED_LIBS before processing liblua

When Lua is included in the build, its CMakeLists.txt enables
BUILD_SHARED_LIBS if it isn't explicitly disabled. This breaks the build
as CMake tries and fails to build all of CAMPVis' libraries as shared
libraries.

Disable BUILD_SHARED_LIBS before including `ext/lua` to prevent that.
Please note that this is a temporary fix; we'd like to eventually build
Lua and at least some of CAMPVis' libraries as shared libraries.

References #1
parent 2be90976
......@@ -48,6 +48,13 @@ IF(CAMPVIS_BUILD_LIB_TGT)
ENDIF()
IF(CAMPVIS_BUILD_LIB_LUA)
# Lua's CMakeLists.txt enables BUILD_SHARED_LIBS if it isn't explicitly disabled. This breaks
# the build as CMake tries and fails to build all of CAMPVis' libraries as shared libraries.
# Disable BUILD_SHARED_LIBS before including `ext/lua` to prevent that.
#
# TODO: this is a temporary fix; we'd like to eventually build Lua and at least some of CAMPVis'
# libraries as shared libraries
SET(BUILD_SHARED_LIBS OFF CACHE BOOL "Build shared libraries")
ADD_SUBDIRECTORY(ext/lua)
ENDIF()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment