Currently job artifacts in CI/CD pipelines on LRZ GitLab never expire. Starting from Wed 26.1.2022 the default expiration time will be 30 days (GitLab default). Currently existing artifacts in already completed jobs will not be affected by the change. The latest artifacts for all jobs in the latest successful pipelines will be kept. More information: https://gitlab.lrz.de/help/user/admin_area/settings/continuous_integration.html#default-artifacts-expiration

Commit 32780169 authored by Artur Grunau's avatar Artur Grunau
Browse files

Disable BUILD_SHARED_LIBS before processing liblua

When Lua is included in the build, its CMakeLists.txt enables
BUILD_SHARED_LIBS if it isn't explicitly disabled. This breaks the build
as CMake tries and fails to build all of CAMPVis' libraries as shared
libraries.

Disable BUILD_SHARED_LIBS before including `ext/lua` to prevent that.
Please note that this is a temporary fix; we'd like to eventually build
Lua and at least some of CAMPVis' libraries as shared libraries.

References #1
parent 2be90976
......@@ -48,6 +48,13 @@ IF(CAMPVIS_BUILD_LIB_TGT)
ENDIF()
IF(CAMPVIS_BUILD_LIB_LUA)
# Lua's CMakeLists.txt enables BUILD_SHARED_LIBS if it isn't explicitly disabled. This breaks
# the build as CMake tries and fails to build all of CAMPVis' libraries as shared libraries.
# Disable BUILD_SHARED_LIBS before including `ext/lua` to prevent that.
#
# TODO: this is a temporary fix; we'd like to eventually build Lua and at least some of CAMPVis'
# libraries as shared libraries
SET(BUILD_SHARED_LIBS OFF CACHE BOOL "Build shared libraries")
ADD_SUBDIRECTORY(ext/lua)
ENDIF()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment