Currently job artifacts in CI/CD pipelines on LRZ GitLab never expire. Starting from Wed 26.1.2022 the default expiration time will be 30 days (GitLab default). Currently existing artifacts in already completed jobs will not be affected by the change. The latest artifacts for all jobs in the latest successful pipelines will be kept. More information: https://gitlab.lrz.de/help/user/admin_area/settings/continuous_integration.html#default-artifacts-expiration

Commit dc70251d authored by Christian Schulte zu Berge's avatar Christian Schulte zu Berge
Browse files

Added C4251 to the ignore list for MSVC warnings, occuring due to missing...

Added C4251 to the ignore list for MSVC warnings, occuring due to missing template instantiations of the standard library used in public interfaces of tgt and campvis code. Even though articles such as <http://support.microsoft.com/kb/168958/en-us> provide a clean solution to fix these warnings, I decided that exporting bazillions of std library templates is not worth the effort. As we do not plan to ship TGT without the rest to a variety of systems, the missing exports won't be a problem.
BTW: The original tgt library build scripts also deactivate the warning. :)

closes #376
parent 04874cbd
......@@ -70,6 +70,7 @@ IF(WIN32)
LIST(APPEND CampvisGlobalDefinitions "-DNOMINMAX" "-D_CRT_SECURE_NO_DEPRECATE")
# Disable warnings for Microsoft compiler:
# C4251 class needs to have dll interface (used for std classes)
# C4290: C++ exception specification ignored except to indicate a function is
# not __declspec(nothrow)
# C4390: ';' : empty controlled statement found; is this the intent?
......@@ -77,7 +78,7 @@ IF(WIN32)
# C4503: The decorated name was longer than the compiler limit (4096), and was truncated.
# Occurs in AutoEvaluatePipeline due to some nested nested map-iterator-map. Could
# not be deactivated locally...
LIST(APPEND CampvisGlobalDefinitions /wd4290 /wd4390 /wd4503)
LIST(APPEND CampvisGlobalDefinitions /wd4251 /wd4290 /wd4390 /wd4503)
# enable parallel builds in Visual Studio
LIST(APPEND CampvisGlobalDefinitions /MP)
......@@ -92,7 +93,7 @@ IF(WIN32)
IF(CAMPVIS_SHARED_LIBS)
# Linking against Windows DLLs requires explicit instantiation of templates
LIST(APPEND CampvisGlobalDefinitions "-DDLL_TEMPLATE_INST")
LIST(APPEND CampvisGlobalDefinitions "-DVRN_DYNAMIC_LIBS")
LIST(APPEND CampvisGlobalDefinitions "-DCAMPVIS_DYNAMIC_LIBS")
IF(NOT CAMPVIS_GENERATE_MANIFEST)
# Do not embed manifest into binaries in debug mode (slows down incremental linking)
......
......@@ -87,7 +87,7 @@
/**
* This is needed for .dll or .so support respectively
*/
#ifdef VRN_DYNAMIC_LIBS
#ifdef CAMPVIS_DYNAMIC_LIBS
#ifdef TGT_BUILD_DLL
#ifdef WIN32
#define TGT_API __declspec(dllexport)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment