Pipeline for merge request (#58) · Issues · IP / elsa

Pipeline for merge request

It would be nice to run the master pipeline on branches before merging.

Gitllab CI supports this in a couple of different stages.

Merge request pipelines, these run jobs specifically if a merge request is created or updated. The pipeline fetches the latest code from the source branch and run the specified jobs against it. We could define the jobs, we usually run nightly (such as sanitizer and code coverage), to run against merge requests as well.
Pipelines for merge requests, this feature can be activated for the project. Quote from the documentation: "With pipelines for merged results, the pipeline runs as if the changes from the source branch have already been merged into the target branch.". And if the pipelines fails, the merge will be rejected.

I think, these two features will improve our merge process. I hope they remove the need to trigger the nightly pipeline manually and rather do that, before we actually merge things into master.

Any thoughts?

It would be nice to run the master pipeline on branches before merging.

Gitllab CI supports this in a couple of different stages.

1. [Merge request pipelines](https://docs.gitlab.com/ee/ci/merge_request_pipelines/), these run jobs specifically if a merge request is created or updated. The pipeline fetches the latest code from the source branch and run the specified jobs against it. We could define the jobs, we usually run nightly (such as sanitizer and code coverage), to run against merge requests as well.

2. [Pipelines for merge requests](https://docs.gitlab.com/ee/ci/merge_request_pipelines/pipelines_for_merged_results/index.html), this feature can be activated for the project. Quote from the documentation: "With pipelines for merged results, the pipeline runs as if the changes from the source branch have already been merged into the target branch.". And if the pipelines fails, the merge will be rejected.

I think, these two features will improve our merge process. I hope they remove the need to trigger the nightly pipeline manually and rather do that, before we actually merge things into master.

Any thoughts?