- compile.py - removed obsolete compile children method

0b2dd583 · Eckhart Arnold · d43a732c · 0b2dd583 · 0b2dd583 · 0b2dd583
Commit 0b2dd583 authored May 03, 2019 by Eckhart Arnold
Hide whitespace changes
Inline Side-by-side

Showing with 22 additions and 13 deletions

DHParser/compile.py DHParser/compile.py +12 -12

examples/XML/XMLCompiler.py examples/XML/XMLCompiler.py +1 -1

examples/XML/example2.xml examples/XML/example2.xml +9 -0

No files found.
--- a/DHParser/compile.py
+++ b/DHParser/compile.py
@@ -131,23 +131,23 @@ class Compiler:
        result = self.compile(root)
        return result
-    def compile_children(self, node: Node) -> StrictResultType:
+    # Obsolete, because never used...
-        """Compiles all children of the given node and returns the tuple
+    # def compile_children(self, node: Node) -> StrictResultType:
-        of the compiled children or the node's (potentially empty) result
+    #     """Compiles all children of the given node and returns the tuple
-        in case the node does not have any children.
+    #     of the compiled children or the node's (potentially empty) result
-        """
+    #     in case the node does not have any children.
-        if node.children:
+    #     """
-            return tuple(self.compile(child) for child in node.children)
+    #     if node.children:
-        else:
+    #         return tuple(self.compile(child) for child in node.children)
-            return node.result
+    #     else:
+    #         return node.result
    def fallback_compiler(self, node: Node) -> Any:
        """This is a generic compiler function which will be called on
        all those node types for which no compiler method `on_XXX` has
        been defined."""
        if node.children:
-            result = tuple(self.compile(nd) for nd in node.children)
+            node.result = tuple(self.compile(nd) for nd in node.children)
-            node.result = result
        return node
    def compile(self, node: Node) -> Any:
@@ -253,7 +253,7 @@ def compile_source(source: str,
            # which could (fatally) break AST transformations.
            try:
                transformer(syntax_tree)
-            except Excpetion as e:
+            except Exception as e:
                syntax_tree.new_error(syntax_tree,
                                      "AST-Transformation failed due to earlier parser errors. "
                                      "Crash Message: " + str(e), Error.AST_TRANSFORM_CRASH)

--- a/examples/XML/XMLCompiler.py
+++ b/examples/XML/XMLCompiler.py
@@ -573,7 +573,7 @@ class XMLCompiler(Compiler):
            node.attr.update(attributes)
            preserve_whitespace |= attributes.get('xml:space', '') == 'preserve'
        node.tag_name = tag_name
-        content = self.compile_children(node.get('content', PLACEHOLDER))
+        content = tuple(self.compile(nd) for nd in node.get('content', PLACEHOLDER).children)
        if len(content) == 1:
            if content[0].tag_name == "CharData":
                # reduce single CharData children

--- a/examples/XML/example2.xml
+++ b/examples/XML/example2.xml
+<?xml version="1.0" encoding="UTF-8"?>
+<note date="2018-06-14">
+  <to>Tove</to>
+  <from>Jani</from>
+  <heading>Reminder</heading>
+  <body> Don't forget me this weekend! </body>
+  <priority level="high" />
+  Some Mixed Content...
+</note>
\ No newline at end of file