Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
ExaHyPE-Engine
ExaHyPE-Engine
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards

11.3.2021, 9:00 - 11:00: Due to updates GitLab may be unavailable for some minutes between 09:00 and 11:00.

  • ExaHyPE
  • ExaHyPE-EngineExaHyPE-Engine
  • Issues
  • #60

Closed
Open
Opened Sep 14, 2016 by Sven Köppel@svenkOwner

Spec file parsing errors in comments

This specification file does not compile:

....
  optimisation
    fuse-algorithmic-steps        = on
    fuse-algorithmic-steps-factor = 0.99
  end optimisation

  /*
    Q0         = das skalare Feld "dens", die relativistische ruhemasse,
    (Q1,Q2,Q3) = den relativistischen Geschwindigkeitsvektor (Impuls),
    Q4         = das skalare Feld der inneren Energie (Hydrodynamik),
    (Q5,Q6,Q7) = das Magnetfeld (Vektorfeld, für SRHD=0).
    Q8         = Die Divergenz des Magnetfelds, die verschwinden muss und ein Mass fuer die numerische Exaktheit ist
   */
  solver ADER-DG MHDSolver
    variables          = 9
    parameters         = 0
    order              = 3
...

This is due to the comment. Comments in the specification file are not working like comments but they are parsed. The comment was actually added by Tobias himself in https://gitlab.lrz.de/gi26det/ExaHyPE/commit/3f7028f1989ce5367d92336a09bb25fc640eca43 and when doing this, the toolkit fails with the unhelpful message IOException: "Pushback buffer overflow", without mentioning any line number or so.

This is a real drawback of the proprietary configuration file format, as already mentioned by Fabian in https://gitlab.lrz.de/gi26det/ExaHyPE/issues/56#note_16127. If we had instead a simple configuration format as INI, JSON, YAML or so, such errors would not occur and instead, we could have fail proof comments like /* comment */, // comment or # comment.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: exahype/ExaHyPE-Engine#60