AreaDensityVoronoiProcessor - Attributes not clear
It is not clear how to assign the two attributes
voronoiMeasurementAreaId of the AreaDensityVoronoiProcessor.
voronoiMeasurementAreaId is the area in which the density is calculated while
measurementAreaId is the area in which the Voronoi Diagram is drawn for the calculation of the density.
What is the current bug behavior?
It seems counter-intuitive that the voronoiMeasurementAreaId is the area that should be smaller. Also, there is no check if the
measurementAreaId is larger or equal to the
voronoiMeasurementAreaId to assure that it's properly used.
What is the expected correct behavior?
It would be better to rename the attributes to e.g.
measurementAreaId (for the small area) and
voronoiDiagramArea for the larger area (up for discussion).
At the moment, I understand that the attribute
measurementAreaId comes from the extension of the AreaDensityProcessor or AttributesProcessor, respectively.
In my opinion, this inherited attribute should be the area in which we are interested in so that it is consistent with all other density processor. This is currently not the case.
Careful: Most probably, the renaming of the attributes has to be handled by the MigrationAssistant (@hm-schuhba1)! Otherwise, I think old scenarios will not be compatible anymore.
Steps to reproduce
Use any *.scenario file, add the AreaDensityVoronoiProcessor and two measurementAreas that you want to use. Change the ids for the attributes in the AreaDensityVoronoiProcessor and look at the results to observe the differences in the results. Sidenote: If you have used the processors in the wrong way, you will most likely see discrete levels of densities in the output file.
Correctly assigned area ids:
AttributesAreaDensityVoronoiProcessorfor renaming the attribute
AreaDensityVoronoiProcessorinit method to interchange the use of the two processors
- MigrationAssistant to assure that we stay compatible with old versions