Skip to content
Snippets Groups Projects
  1. Apr 30, 2020
  2. Apr 15, 2020
    • Todd Gamblin's avatar
    • Todd Gamblin's avatar
      version bump: 0.14.2 · a3bcd88f
      Todd Gamblin authored
      a3bcd88f
    • Todd Gamblin's avatar
      bugfix: spack test should not output [+] for mock installs (#15609) · 740f8fe1
      Todd Gamblin authored
      `spack test` has a spurious '[+] ' in the output:
      
      ```
      lib/spack/spack/test/install.py .........[+] ......
      ```
      
      Output is properly suppressed:
      
      ```
      lib/spack/spack/test/install.py ...............
      ```
      740f8fe1
    • Todd Gamblin's avatar
      `spack install` terminal output handling in foreground/background (#15723) · 430ca7c7
      Todd Gamblin authored
      
      Makes the following changes:
      
      * (Fixes #15620) tty configuration was failing when stdout was 
        redirected. The implementation now creates a pseudo terminal for
        stdin and checks stdout properly, so redirections of stdin/out/err
        should be handled now.
      * Handles terminal configuration when the Spack process moves between
        the foreground and background (possibly multiple times) during a
        build.
      * Spack adjusts terminal settings to allow users to to enable/disable
        build process output to the terminal using a "v" toggle, abnormal
        exit cases (like CTRL-C) could leave the terminal in an unusable
        state. This is addressed here with a special-case handler which
        restores terminal settings.
      
      Significantly extend testing of process output logger:
      
      * New PseudoShell object for setting up a master and child process
        and configuring file descriptor inheritance between the two
      * Tests for "v" verbosity toggle making use of the added PseudoShell
        object
      * Added `uniq` function which takes a list of elements and replaces
        any consecutive sequence of duplicate elements with a single
        instance (e.g. "112211" -> "121")
      
      Co-authored-by: default avatarAdam J. Stewart <ajstewart426@gmail.com>
      430ca7c7
    • Massimiliano Culpo's avatar
      database: maintain in-memory consistency on remove (#15777) · 55f5afaf
      Massimiliano Culpo authored
      The performance improvements done in #14693 where leaving the DB in an inconsistent state when specs were removed from it. This PR updates the DB internal state whenever the DB is written to a file.
      
      Note that we still cannot properly enumerate installed dependents, so there is a TODO in this code. Fixing that will require the dependents dictionaries in specs to be re-keyed (either by hash, or not keyed at all -- a list would do).  See #11983 for details.
      55f5afaf
    • Andrew W Elble's avatar
      performance: add a verification file to the database (#14693) · 6b559912
      Andrew W Elble authored
      Reading the database repeatedly can be quite slow.  We need a way to speed
      up Spack when it reads the DB multiple times, but the DB has not been
      modified between reads (which is nearly all the time).
      
      - [x] Add a file containing a unique uuid that is regenerated at database
          write time. Use this uuid to suppress re-parsing the database
          contents if we know a previous uuid and the uuid has not changed.
      
      - [x] Fix mutable_database fixture so that it resets the last seen
          verifier when it resets.
      
      - [x] Enable not rereading the database immediately after a write. Make
          the tests reset the last seen verifier in between tests that use the
          database fixture.
      
      - [x] make presence of uuid module optional
      6b559912
    • Peter Scheibel's avatar
      Remove DB conversion of old index.yaml (#15298) · 9b5805a5
      Peter Scheibel authored
      Removed the code that was converting the old index.yaml format into
      index.json. Since the change happened in #2189 it should be
      considered safe to drop this (untested) code.
      9b5805a5
    • Adam J. Stewart's avatar
      Allow Spack Environments with '-h' in the name (#15429) · c6c1d01a
      Adam J. Stewart authored
      If a user invoked "spack env activate example-henv", Spack would
      mistakenly interpret the "-h" from "example-henv" as the "-h" option.
      This commit allows users to create and activate environments with
      "-h" in the name.
      
      This issue existed for bash shell support as well as csh support, and
      this commit addresses both, along with some other unrelated csh
      support issues.
      c6c1d01a
    • Peter Scheibel's avatar
      Environments/views: only override spec prefix for non-external packages (#15475) · b9688a8c
      Peter Scheibel authored
      * only override spec prefix for non-external packages
      
      * add test that environment shell modifications respect explicitly-specified prefixes for external packages
      
      * add clarifying comment
      b9688a8c
    • Jonathon Anderson's avatar
      Source devnull in environment_after_sourcing_files (closes #15775) (#15791) · ed278197
      Jonathon Anderson authored
      spack.util.environment_after_sourcing_files compares the local
      environment against a shell environment after having sourced a
      file; but this ends up including the default shell profile and
      rc, which might differ from the local environment.
      
      To change this, compare against the default shell environment,
      expressed here as 'source /dev/null'.
      ed278197
    • Todd Gamblin's avatar
    • Massimiliano Culpo's avatar
      Blacklist Lmod variable modifications when sourcing files (#15778) · a85cce05
      Massimiliano Culpo authored
      fixes #15775
      
      Add all the variables listed here:
      
      https://lmod.readthedocs.io/en/latest/090_configuring_lmod.html
      
      to the list of those blacklisted when constructing environment
      modifications by sourcing files.
      a85cce05
  3. Mar 20, 2020
  4. Feb 24, 2020
  5. Feb 22, 2020
Loading