Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
ExaHyPE-Engine
ExaHyPE-Engine
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ExaHyPE
  • ExaHyPE-EngineExaHyPE-Engine
  • Issues
  • #296

Closed
Open
Opened Sep 11, 2019 by Jean-Matthieu Gallard@ga96nuvDeveloper

GradQ format

The format of gradQ (used by NCP and ViscousFlux) is not consistent

  • Linear => like F for the flux PDE so gradQ[nDim][nVar]
  • Nonlinear => all in one dimension gradQ[nDim*nVar]
  • FV => all in one dimension but with param gradQ[nDim*nData]

Changing this will change the user API and break some application, however a simple adapter could allow them to run until a more in depth correction is done.

Do we need the parameter in FV?

This would also be a good time to maybe change BgradQ similarly if possible (I don't know it it would make sense) so that linear and nonlinear have the same API, even if it introduce a slight inefficiency in nonlinear/FV

@reinarz @domcha @ga24dib @leo.rannabauer

Edited Sep 11, 2019 by Jean-Matthieu Gallard
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: exahype/ExaHyPE-Engine#296