Skip to content

GitLab

Notice to GitKraken users: A vulnerability has been found in the SSH key generation of GitKraken versions 7.6.0 to 8.0.0 (https://www.gitkraken.com/blog/weak-ssh-key-fix). If you use GitKraken and have generated a SSH key using one of these versions, please remove it both from your local workstation and from your LRZ GitLab profile.

21.10.2021, 9:00 - 11:00: Due to updates GitLab may be unavailable for some minutes between 09:00 and 11:00.

Open
Created by Jean-Matthieu Gallard@ga96nuvDeveloper

GradQ format

The format of gradQ (used by NCP and ViscousFlux) is not consistent

  • Linear => like F for the flux PDE so gradQ[nDim][nVar]
  • Nonlinear => all in one dimension gradQ[nDim*nVar]
  • FV => all in one dimension but with param gradQ[nDim*nData]

Changing this will change the user API and break some application, however a simple adapter could allow them to run until a more in depth correction is done.

Do we need the parameter in FV?

This would also be a good time to maybe change BgradQ similarly if possible (I don't know it it would make sense) so that linear and nonlinear have the same API, even if it introduce a slight inefficiency in nonlinear/FV

@reinarz @domcha @ga24dib @leo.rannabauer

Edited by Jean-Matthieu Gallard